Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor processors and add LPR postprocessing #16722

Merged
merged 17 commits into from
Feb 21, 2025
Merged

Refactor processors and add LPR postprocessing #16722

merged 17 commits into from
Feb 21, 2025

Conversation

hawkeye217
Copy link
Collaborator

Proposed change

This PR:

  • Refactors the real time and post processors to improve the file structure.
  • Adds recording data ZMQ pub/sub.
  • Adds a model runner and mixin class for LPR so the same models and code path can be used for LPR real-time and postprocessing.
  • Adds an LPR postprocessor to take a snapshot from the record stream (if recordings are enabled) to make a final refinement of previously detected/recognized plates.
  • Adds the framework for a postprocessor endpoint for LPR. Still need to determine how to get a "best" time to use for the recordings snapshot API, so this is mostly non-functional.
  • Makes small tweaks to the LPR pipeline.
  • Updates LPR docs.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

@netlify Netlify
Copy link

netlify bot commented Feb 21, 2025 •
edited
Loading

✅ Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit db75e78
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/67b8828556beec0008b6803b
😎 Deploy Preview https://deploy-preview-16722--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NickM-27 NickM-27 merged commit 60b34bc into dev Feb 21, 2025
12 checks passed
@NickM-27 NickM-27 deleted the lpr-post-process branch February 21, 2025 13:51
@daoudeddy
Copy link

daoudeddy commented Feb 21, 2025 •
edited
Loading 

2025-02-21 14:36:04.047341308  Traceback (most recent call last):
2025-02-21 14:36:04.047343278    File "/usr/lib/python3.11/multiprocessing/process.py", line 314, in _bootstrap
2025-02-21 14:36:04.047344578      self.run()
2025-02-21 14:36:04.047346188    File "/opt/frigate/frigate/util/process.py", line 41, in run_wrapper
2025-02-21 14:36:04.047348440      return run(*args, **kwargs)
2025-02-21 14:36:04.047374537             ^^^^^^^^^^^^^^^^^^^^
2025-02-21 14:36:04.047376300    File "/usr/lib/python3.11/multiprocessing/process.py", line 108, in run
2025-02-21 14:36:04.047378294      self._target(*self._args, **self._kwargs)
2025-02-21 14:36:04.047379923    File "/opt/frigate/frigate/embeddings/__init__.py", line 61, in manage_embeddings
2025-02-21 14:36:04.047381290      maintainer = EmbeddingMaintainer(
2025-02-21 14:36:04.047382654                   ^^^^^^^^^^^^^^^^^^^^
2025-02-21 14:36:04.047413770    File "/opt/frigate/frigate/embeddings/maintainer.py", line 104, in __init__
2025-02-21 14:36:04.047415692      self.realtime_processors.append(FaceRealTimeProcessor(self.config, metrics))
2025-02-21 14:36:04.047417930                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025-02-21 14:36:04.047419484    File "/opt/frigate/frigate/data_processing/real_time/face.py", line 32, in __init__
2025-02-21 14:36:04.047440074      super().__init__(config, metrics)
2025-02-21 14:36:04.047442018  TypeError: RealTimeProcessorApi.__init__() missing 1 required positional argument: 'model_runner'```

@hawkeye217 hawkeye217 mentioned this pull request Feb 21, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickM-27 NickM-27 NickM-27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawkeye217 @daoudeddy @NickM-27